|
On Fri, Jul 25, 2008 at 02:34:55AM -0700, Andrew Morton wrote:
We should make arch_pick_mmap_layout __weak and nuke that ifdef.
I strongly disagree. I find it makes it harder to follow code flow
when __weak functions are involved. Ifdefs are ugly, no question, but
theyre easier to grep for, see when theyll be defined and know which of
the arch_pick_mmap_layout() functions will be called. __weak certainly
has its uses (eg the sys_ni_syscall is great) but I find its becoming
overused.
My basic point here is that __weak makes the code easier to write but
harder to read, and were supposed to be optimising for easier to read.
--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that youre interested in selling us this
operating system, but compare it to ours. We cant possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe linux-arch" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at rel="nofollow" vger.kernel.org/majordomo-info.html vger.kernel.org/majordomo-info.html
|
