|
-----Message dorigine-----
De : Nicolas Pitre [ rel="nofollow" mailto:nico@xxxxxxx mailto:nico@xxxxxxx ]
Envoye : 23 mars 2006 23:09
A : Marc-Andre Hebert
Cc : Russell King - ARM Linux; linux-arm@xxxxxxxxxxxxxxxxxxxxxx
Objet : RE: Booting with 2.6.15.1
On Thu, 23 Mar 2006, Nicolas Pitre wrote:
On Thu, 23 Mar 2006, Marc-Andre Hebert wrote:
Havent found much on the mailing list on the cachepolicy but
Im comparing
my mtd map file against the lubbock-flash.c and Im seeing some calls
concerning cache that I dont have. So thats probably it.
Ill try updating
my code tomorrow morning.
No -- those are unrelated. They will increase read performance
from the
flash, and even possibly move the actual bug around by changing the
cache usage pattern. But the fundamental issue wont be fixed
(which is
btw only a single line that needs to be added to the appropriate place
in mtdblock.c.
OK, just to confirm my suspicion, could you remove the
cachepolicy=writethrough and test this patch, and confirm that it
doesnt work without the patch:
diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd/mtd_blkdevs.c
index 7f3ff50..66826e9 100644
--- a/drivers/mtd/mtd_blkdevs.c
+++ b/drivers/mtd/mtd_blkdevs.c
@@ -54,9 +54,11 @@ static int do_blktrans_request(struct mt
switch(rq_data_dir(req)) {
case READ:
- for (; nsect 0; nsect--, block++, buf += 512)
+ for (; nsect 0; nsect--, block++, buf += 512) {
if (tr- readsect(dev, block, buf))
return 0;
+ dmac_clean_range((u32)buf, (u32)buf + 512);
+ }
return 1;
case WRITE:
Nicolas
Suspicion confirmed, It works with the patch but not without.
Marc
-------------------------------------------------------------------
List admin: rel="nofollow" lists.arm.linux.org.uk/mailman/listinfo/linux-arm lists.arm.linux.org.uk/mailman/listinfo/linux-arm
FAQ: rel="nofollow" www.arm.linux.org.uk/mailinglists/faq.php www.arm.linux.org.uk/mailinglists/faq.php
Etiquette: rel="nofollow" www.arm.linux.org.uk/mailinglists/etiquette.php www.arm.linux.org.uk/mailinglists/etiquette.php
|
